Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1407] Add Subclass advancement & selection interface on sheet #4072

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Aug 29, 2024

Introduces a new subclass advancement! This advancement doesn't do anything on its own other than indicate the level at which the class takes a subclass due to limitations in the advancement system.

Subclass Advancement - List Subclass Advancement - Flow

When a player reaches the level of the subclass advancement, their features tab adds a "Add Subclass" button where the subclass icon will eventually appear. Clicking this opens the compendium browser with the subclass list locked to the current class's identifier.

Subclass Advancement - Add Button Subclass Advancement - Browser

While this doesn't fully implement what was originally desired from the subclass advancement, this workflow should work pretty well to fill in a major gap in the system's level-up workflow.

Closes #1017
Closes #1407

Introduces a new subclass advancement! This advancement doesn't do
anything on its own other than indicate the level at which the
class takes a subclass due to limitations in the advancement
system.

When a player reaches the level of the subclass advancement, their
features tab adds a "Add Subclass" button where the subclass icon
will eventually appear. Clicking this opens the compendium browser
with the subclass list locked to the current class's identifier.

While this doesn't fully implement what was originally desired
from the subclass advancement, this workflow should work pretty
well to fill in a major gap in the system's level-up workflow.

Closes #1017
Closes #1407
@arbron arbron added feature request ux User experience related features or bugs system: advancement labels Aug 29, 2024
@arbron arbron added this to the D&D5E 4.0.0 milestone Aug 29, 2024
@arbron arbron requested a review from Fyorl August 29, 2024 19:25
@arbron arbron self-assigned this Aug 29, 2024
icons/svg/subclass.svg Outdated Show resolved Hide resolved
module/documents/advancement/subclass.mjs Outdated Show resolved Hide resolved
templates/actors/parts/actor-classes.hbs Outdated Show resolved Hide resolved
@arbron arbron merged commit 4954cec into 4.0.x Aug 30, 2024
@arbron arbron deleted the advancement/subclass-simple branch August 30, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request system: advancement ux User experience related features or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advancement Type: Subclass Add subclassing information to Class item
3 participants