Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cf-macro): allow functions with no Metadata (#99) #101

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

eoinsha
Copy link
Contributor

@eoinsha eoinsha commented Oct 12, 2022

Fix #99 , ensuring functions with no Metadata can be processed with SLIC Watch config defaults

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eoinsha eoinsha self-assigned this Oct 12, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 70df80a on fix-no-metadata-in-macro-functions into 064d10f on main.

@eoinsha eoinsha merged commit 9db4cc6 into main Oct 12, 2022
@eoinsha eoinsha deleted the fix-no-metadata-in-macro-functions branch October 12, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudFormation macro fails for lambdas unless per-function metadata is specified.
2 participants