Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support OK actions for alarms #112

Merged
merged 2 commits into from
Nov 4, 2023
Merged

feat: support OK actions for alarms #112

merged 2 commits into from
Nov 4, 2023

Conversation

eoinsha
Copy link
Contributor

@eoinsha eoinsha commented Nov 3, 2023

This PR replaces #85 since the codebase has change significantly since

Add ok actions to notify if alarm is resolved.

Description

Resolves #84

Motivation and Context

CloudWatch Alarms support notifications to the same or other/additional topics when the alarm is resolved (ALARM -> OK). To date, SLIC Watch did not support this, only OK -> ALARM

How Has This Been Tested?

  • npm t
  • Deployment and manual validation of test projets

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Co-authored-by: David <david_tjokroaminoto@tech.gov.sg>
@coveralls
Copy link

coveralls commented Nov 3, 2023

Coverage Status

coverage: 100.0%. remained the same
when pulling 32d2e06 on ok-alarm-actions
into 327a6f3 on main.

@eoinsha eoinsha requested a review from direnakkoc November 3, 2023 14:15
Copy link
Collaborator

@direnakkoc direnakkoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eoinsha eoinsha merged commit 2a9144a into main Nov 4, 2023
3 checks passed
@eoinsha eoinsha deleted the ok-alarm-actions branch November 4, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNS notification on alarm resolve
3 participants