feat(tests): add snapshot tests for all test projects #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlynam01
approved these changes
Dec 1, 2023
cf-macro/index.ts
Outdated
| @@ -6,7 +6,8 @@ import { setLogger } from 'slic-watch-core/logging' | |||
| import { type SlicWatchConfig, resolveSlicWatchConfig } from 'slic-watch-core/inputs/general-config' | |||
| import { type Template } from 'cloudform-types' | |||
|
|
|||
| const logger = pino({ name: 'macroHandler' }) | |||
| const logger = pino({ name: 'macroHandler', level: process.env.DEBUG_LEVEL ?? 'DEBUG' }) | |||
There was a problem hiding this comment.
do we want the default debug level to be DEBUG
There was a problem hiding this comment.
I guess it keeps the status quo
There was a problem hiding this comment.
Yes, exactly. I think it's useful to have the input and output stack visible in the Macro function's logs but want to suppress it during test runs.
sam-test-project/tests/snapshot/sam-test-project-snapshot.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: David Lynam <david.lynam@fourtheorem.com>
direnakkoc
reviewed
Dec 1, 2023
eoinsha
force-pushed
the
add-snapshot-testing
branch
from
6e98ebb to
1c48c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add snapshot tests for all test projects
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: