Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alb): allow actions with no TargetGroup #123

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix(alb): allow actions with no TargetGroup #123

merged 1 commit into from
Nov 12, 2024

Conversation

eoinsha
Copy link
Contributor

@eoinsha eoinsha commented Nov 12, 2024

Fixes #122

@eoinsha eoinsha requested a review from direnakkoc November 12, 2024 17:55
@coveralls
Copy link

Coverage Status

coverage: 97.615%. remained the same
when pulling 3963629 on fix/allow-alb-no-tg-ref
into c7a788e on main.

direnakkoc
direnakkoc approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@direnakkoc direnakkoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eoinsha eoinsha merged commit d532930 into main Nov 12, 2024
5 checks passed
@eoinsha eoinsha deleted the fix/allow-alb-no-tg-ref branch November 12, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@direnakkoc direnakkoc direnakkoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ALB Target Group processing fails if Actions don't have a Target Group ARN
3 participants
@eoinsha @coveralls @direnakkoc