Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates test project to sls v3 and solve datetime validation issue #80

Merged
merged 8 commits into from
May 15, 2022

Conversation

lmammino
Copy link
Contributor

@lmammino lmammino commented May 2, 2022

This PR updates the test project to Serverless framework v3

It also closes an issue with the date time validation in the configuration:

Finally there are some minor aesthetic improvements:

  • Added README in test project
  • Updated CI to run also under Node.js 18

@coveralls
Copy link

coveralls commented May 2, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling e0b04ad on update-serverless-test-project-to-v3 into ee9ffca on main.

@lmammino lmammino marked this pull request as ready for review May 2, 2022 12:10
@lmammino lmammino requested review from eoinsha and guidr May 2, 2022 12:10
@lmammino lmammino self-assigned this May 2, 2022
@dchocoboo
Copy link
Contributor

hi, just wondering if this is going to be merged?

@eoinsha
Copy link
Contributor

eoinsha commented May 11, 2022

@dchocoboo We want to add automated testing for serverless@2 and serverless@3 support and plan do to it later this week. In the meantime, is it helpful for you if we publish a pre-release of this branch to npm?

@dchocoboo
Copy link
Contributor

@eoinsha yes please, thank you.
i'll be using it for my production, will feedback if theres any other build issues

@eoinsha
Copy link
Contributor

eoinsha commented May 11, 2022

@dchocoboo 1.1.0-rc1 has been published from this branch. You can install it with

npm install serverless-slic-watch-plugin@next

Great to get your feedback, thank you!

@eoinsha eoinsha force-pushed the update-serverless-test-project-to-v3 branch from 53aee12 to e0b04ad Compare May 15, 2022 10:33
@eoinsha eoinsha merged commit 7c3d014 into main May 15, 2022
@eoinsha eoinsha deleted the update-serverless-test-project-to-v3 branch May 15, 2022 10:37
@eoinsha
Copy link
Contributor

eoinsha commented May 15, 2022

@dchocoboo v3 support is now fully available in release 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serverless 3 - invalid regular expression error, cannot deploy
4 participants