add feedback form to answer detail page #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capsert
requested changes
Apr 30, 2024
apps/feedback/models/models.py
Outdated
| help_text=_("(0 = not clear, 5 = very clear)"), null=True, blank=True | ||
| ) | ||
| reliability_grade = models.PositiveSmallIntegerField( | ||
| verbose_name=_("Do you find this KlimaatHelpdesk article reliable?"), |
apps/feedback/models/models.py
Outdated
| user_email = models.EmailField( | ||
| verbose_name=_("Email"), | ||
| help_text=_("We will forward the expert's response when we receive it."), | ||
| null=True, |
There was a problem hiding this comment.
null=True hoeft nooit bij textvelden met blank. Blank zorgt er voor dat het db veld gevuld wordt met een lege string ("")
There was a problem hiding this comment.
Dit geldt voor alle text/char velden in dit model.
apps/feedback/forms.py
Outdated
| required=True, | ||
| ) | ||
| reliability_grade = forms.IntegerField( | ||
| label=_("Do you find this KlimaatHelpdesk article reliable?*"), |
apps/feedback/models/pages.py
Outdated
|
|
||
| template = "feedback/feedback_form_page.html" | ||
| context = self.get_context(request) | ||
| Answer = apps.get_model(app_label='cms', model_name='Answer') |
There was a problem hiding this comment.
Waarom haal je op deze manier het model op? ipv gewoon importeren?
There was a problem hiding this comment.
omdat ik wagtail_helpdesk nog via pip install -e had geinstalleerd en dan werkt importeren niet. ik pas het aan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.