Address #38, #39 #45
Address #38, #39 #45
Conversation
Clean up Ediff buffers and restore window configuration (back to `ztree`) after quitting Ediff session.
ztree-diff.el
Outdated
| @@ -95,6 +95,8 @@ By default paths starting with dot (like .git) are ignored") | |||
| (defvar-local ztree-diff-wait-message nil | |||
| "Message showing while constructing the diff tree.") | |||
|
|
|||
| (defvar ztree-diff--ediff-previous-window-configuration nil | |||
There was a problem hiding this comment.
there is no conventions on private variables in ztree to have double dashes, please remove one.
Also please use defvar-local since we are allowing multiple ztree buffers
There was a problem hiding this comment.
Done.
You should use double dashes for private variables/functions--it's Emacs convention, and helps keep the interface small.
There was a problem hiding this comment.
I don't want to flame on this, but this I see as a more "modern" convention, which is certainly not emacs-wide, as tons of build-in packages are not using it (ediff, dired, gnus etc).
Moreover there are a lot of other "conventions", i.e. ztree/myvariable etc. Maybe I'll change it at some point but I see no reason in it right now..
And in this package I would prefer the consistency in naming anyway, evening if conventions are not that convenient.
Ediff registry buffer may be used by other Ediff sessions. See magit/magit#2975.
|
Thanks, merged! |
Clean up Ediff buffers and restore window configuration (back to
ztree)after quitting Ediff session.
Note: I have signed the FSF's contributor agreement.