Skip to content

Commit

Permalink
Be explicit about the TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
foursixnine committed Feb 2, 2024
1 parent 8221031 commit 82937a6
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions openqabot/types/incident.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,11 +186,13 @@ def filter_failures(self, results):
]


@staticmethod
# pylint: disable=fixme
# TODO:
# - move to utils
# - remove almost duplicated code from Approver.is_job_marked_acceptable_for_incident
# - move to utils.py or a better place
# - remove almost duplicated code from Approver.is_job_marked_acceptable_for_incident
# as approver does not seem to operate over incidents
# about the TODO see discussion at https://github.com/openSUSE/qem-bot/pull/154#discussion_r1472721681
@staticmethod
def has_ignored_comment(job_id: int, inc: int):
ret = []
ret = requests.get(OPENQA_URL + "/api/v1/jobs/%s/comments" % job_id).json()
Expand Down

0 comments on commit 82937a6

Please sign in to comment.