Rework duplicate ordering logic, add feature type preference #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -1 * comparators | ||
| .map(_.compare(a,b)) | ||
| .find(_ !=? 0) // find first non-tie | ||
| .getOrElse(b._2.compare(a._2)) // if all ties, just sort on original order |
There was a problem hiding this comment.
For a slightly better version see http://stackoverflow.com/questions/14695833/scala-idiom-for-ordering-by-multiple-criteria
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to refactor the dupe sorting logic has led me to discover some very dumb choices made in the design of
scala.math.OrderingIt's also impossible to test any of this because everything is defined inside a method. TODO: factor out orderings into a trait etc, do not merge until then.