Add needsRefresh for multiple targets #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffy
changed the title
|
@yglukhov Does this look good to you? |
yglukhov
reviewed
Mar 6, 2019
nakelib.nim
Outdated
| @@ -193,6 +193,38 @@ template withDir*(dir: string; body: untyped): untyped = | |||
| cd(curDir) | |||
|
|
|||
|
|
|||
| proc needsRefresh*(targets: seq[string], src: varargs[string]): bool {.raises: [OSError].} = | |||
There was a problem hiding this comment.
I'd better make both args openarray, for maximum flexibility.
yglukhov
reviewed
Mar 6, 2019
nakelib.nim
Outdated
| var minTargetTime: float = -1 | ||
| for target in targets: | ||
| try: | ||
| let targetTime = toSeconds(getLastModificationTime(target)) |
There was a problem hiding this comment.
I feel like with toSeconds we lose precision that might be important. Can we do better?
There was a problem hiding this comment.
Probably? I just copied the existing implementation (trying not to change too many things at once)
There was a problem hiding this comment.
@yglukhov Are you thinking maybe toWinTime()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the case when a build step produces multiple targets. For my case, using
tscto compile TypeScript files to JavaScript.