Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open EWF segments lazily when needed #18

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Open EWF segments lazily when needed #18

merged 6 commits into from
Aug 16, 2023

Conversation

Schamper
Copy link
Member

No description provided.

@Schamper Schamper self-assigned this Jul 30, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #18 (b151ab9) into main (fe6900e) will increase coverage by 1.14%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   62.90%   64.05%   +1.14%     
==========================================
  Files          11       11              
  Lines         976     1010      +34     
==========================================
+ Hits          614      647      +33     
- Misses        362      363       +1     
Flag Coverage Δ
unittests 64.05% <95.23%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dissect/evidence/ewf.py 88.44% <95.23%> (+1.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there also a PR to fix the EWF loader in dissect.target to work with this?

@Schamper Schamper requested a review from Miauwkeru August 7, 2023 11:29
@Schamper Schamper requested a review from Miauwkeru August 8, 2023 09:34
Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Schamper Schamper merged commit 227e4dd into main Aug 16, 2023
@Schamper Schamper deleted the ewf-lazy-segments branch August 16, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants