Add option to add comments to keychain file (#523)

fox-it · Feb 2, 2024 · 4a5f27f · 4a5f27f
1 parent 6785e1f
commit 4a5f27f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/dissect/target/helpers/keychain.py b/dissect/target/helpers/keychain.py
@@ -89,6 +89,9 @@ def register_keychain_file(keychain_path: Path) -> None:
     with keychain_path.open(mode="r") as fh:
         rows = csv.reader(fh)
         for row in rows:
+            # Skip comment rows (starting with #)
+            if row[0].startswith("#"):
+                continue
             if len(row) != 4:
                 log.warning("Expecting 4 values per row in a keychain CSV file, found %d: %s. Skipping", len(row), row)
                 continue

diff --git a/tests/_data/helpers/keychain/keychain.csv b/tests/_data/helpers/keychain/keychain.csv
@@ -1,3 +1,4 @@
+# Test comment line
 bitlocker,passphrase,,Password1234
 ,passphrase,,AnotherTestPassword
 Bitlocker,recovery_key,,312268-409816-583517-486695-627121-599511-664389-145640