-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NamespacePlugin #334
Add NamespacePlugin #334
Conversation
ca285cf
to
7d52b5e
Compare
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 70.57% 70.70% +0.13%
==========================================
Files 235 235
Lines 18071 18098 +27
==========================================
+ Hits 12753 12796 +43
+ Misses 5318 5302 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0746cc9
to
fe4f2e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add automatic generation of shared functions that have the same (name, record) signature? So that you don't have to manually define functions such as these:
@export(record=BrowserDownloadRecord)
def downloads(self):
yield from self._func("downloads")
Seems that we have to do this statically, maybe using |
You can set |
I believe the long-term goal is to automatically generate the record descriptor documentation. The body of the docstring could be automatically generated to say something like "Convenience function to call {function} on {subplugins}". |
Yes, I deleted my previous comment because I see there is already some duplication in the docs. |
69afe89
to
6ac8585
Compare
f93f564
to
f4e8a00
Compare
Note that the auto-generated functions will have generated docs that reflect the actual aggregation: So
yields:
Also the function that generates these docs is very flexible and accepts a format_spec str to be filled in, so we might reuse this code for other purposes as well. |
20c1e50
to
d558a11
Compare
(DIS-1681)
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
5f7fd46
to
b0b3301
Compare
(DIS-1681)
(DIS-1681)