Handle hardlink or regular file for /etc/localtime #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A symlink is not always guaranteed for /etc/localtime. This adds extra handling for hardlinks and regular files.
Codecov Report
@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 71.78% 71.87% +0.08%
==========================================
Files 238 238
Lines 18704 18717 +13
==========================================
+ Hits 13427 13452 +25
+ Misses 5277 5265 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Schamper
requested changes
Aug 21, 2023
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Schamper
requested changes
Aug 21, 2023
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Schamper
approved these changes
Aug 21, 2023
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
A symlink is not always guaranteed for /etc/localtime. This adds extra handling for hardlinks and regular files. Issue found via: fox-it/citrix-netscaler-triage#4 Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
A symlink is not always guaranteed for /etc/localtime. This adds extra handling for hardlinks and regular files. Issue found via: fox-it/citrix-netscaler-triage#4 Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A symlink is not always guaranteed for /etc/localtime.
This adds extra handling for hardlinks and regular files.
Issue found via: fox-it/citrix-netscaler-triage#4