Fix small bugs in Android OS Plugin #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MaxGroot
commented
Oct 14, 2023
MaxGroot
commented
- Fix incorrect accessing of path on the target's filesystem
- Fix exceptions when build property doesn't contain a security patch
- Add small test
* Fix incorrect accessing of path on the target's filesystem * Fix exceptions when build property doesn't contain a security patch * Add small test
Codecov Report
@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 73.99% 74.38% +0.38%
==========================================
Files 255 256 +1
Lines 20307 20471 +164
==========================================
+ Hits 15027 15227 +200
+ Misses 5280 5244 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Schamper
requested changes
Oct 15, 2023
|
While testing on a different Android system I found some other inconsistencies, I'll make sure to add fixes for those in this PR as well. In the meantime I'm converting it back to draft. |
Schamper
requested changes
Oct 16, 2023
Otherwise, the Linux OS would be selected if Linux were detected.
Schamper
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.