Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Android Backups #419

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Add support for Android Backups #419

merged 7 commits into from
Jul 31, 2024

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Oct 16, 2023

Also some miscellaneous cleanup.

Depends on fox-it/dissect.util#33.

@Schamper Schamper marked this pull request as draft October 16, 2023 18:41
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: Patch coverage is 85.29412% with 30 lines in your changes missing coverage. Please review.

Project coverage is 75.17%. Comparing base (1e38f11) to head (69a29b4).

Files Patch % Lines
dissect/target/loaders/ab.py 84.65% 29 Missing ⚠️
...issect/target/plugins/os/unix/linux/android/_os.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   75.10%   75.17%   +0.06%     
==========================================
  Files         294      295       +1     
  Lines       25130    25315     +185     
==========================================
+ Hits        18875    19031     +156     
- Misses       6255     6284      +29     
Flag Coverage Δ
unittests 75.17% <85.29%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper marked this pull request as ready for review October 21, 2023 20:45
Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed something with a k when using the followin adb flags:

adb backup -all -system -keyvalue -shared

Tho I do not know what it is for... I assume the key value information

@Miauwkeru
Copy link
Contributor

Miauwkeru commented Apr 11, 2024

I was able to verify it now, I did notice there is an issue in firefox.downloads(). Where the moz_anno_attributes does not exist in the table. So rows() is called on a None object.

Additionally, could you add a test for the android stuff in the firefox plugin?

@Schamper Schamper requested a review from Miauwkeru July 15, 2024 15:56
@Schamper Schamper requested a review from Miauwkeru July 26, 2024 11:21
@Schamper Schamper requested a review from Miauwkeru July 29, 2024 11:30
@Schamper Schamper merged commit ff47f07 into main Jul 31, 2024
18 checks passed
@Schamper Schamper deleted the android-backup branch July 31, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants