-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux locate plugin #505
Add Linux locate plugin #505
Conversation
@JSCU-CNI Thats quite some cool new parsers, thanks! We will try and schedule a review for this PR as soon as possible. |
Co-authored-by: Stefan de Reuver <9864602+Horofic@users.noreply.github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 73.79% 73.93% +0.13%
==========================================
Files 279 283 +4
Lines 23272 23453 +181
==========================================
+ Hits 17174 17339 +165
- Misses 6098 6114 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@Horofic it seems that your changes broke the tests. Could you fix them? |
Im aware the tests on pypy3.9 still fail. Not sure why this happens, but it's unrelated to the previous tests failing. Will commit a fix for this as well. |
Thanks for your effort @Horofic. On a side note, are you planning on running tests against |
Yes we are! I am currently in the process of adding tests for pypy3.10 to our pipeline(s). |
I did some digging into this bug, but was unable to figure out what exactly goes wrong in Ill create a seperate PR where I move the * |
We seem to have found somewhat of a workaround for PyPy 3.9. I ain't pretty, but at least it works 😄 |
Co-authored-by: Stefan de Reuver <9864602+Horofic@users.noreply.github.com> Co-authored-by: Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Stefan de Reuver <9864602+Horofic@users.noreply.github.com> Co-authored-by: Schamper <1254028+Schamper@users.noreply.github.com>
This PR adds support for
locate
,mlocate
andplocate
artifacts on Linux targets.