Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schedlgu.txt file parser #511

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Add schedlgu.txt file parser #511

merged 5 commits into from
Jan 23, 2024

Conversation

Horofic
Copy link
Contributor

@Horofic Horofic commented Jan 23, 2024 •
edited by Schamper
Loading

(DIS-2136)

@Horofic Horofic requested a review from Poeloe January 23, 2024 08:29
@Schamper Schamper changed the title DIS-2136 Add schedlgu.txt file parser Add schedlgu.txt file parser Jan 23, 2024
Poeloe
Poeloe requested changes Jan 23, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

Attention: 199 lines in your changes are missing coverage. Please review.

Comparison is base (18d9634) 73.89% compared to head (5d35db4) 73.64%.
Report is 1 commits behind head on main.

Files Patch % Lines
...issect/target/plugins/os/unix/linux/fortios/_os.py 22.02% 177 Missing ⚠️
...ct/target/plugins/os/unix/linux/fortios/generic.py 60.00% 8 Missing ⚠️
...ect/target/plugins/os/unix/linux/fortios/locale.py 61.11% 7 Missing ⚠️
dissect/target/plugins/os/windows/tasks.py 95.58% 3 Missing ⚠️
dissect/target/plugins/os/unix/_os.py 33.33% 2 Missing ⚠️
dissect/target/plugins/os/unix/generic.py 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   73.89%   73.64%   -0.25%     
==========================================
  Files         273      275       +2     
  Lines       22663    22872     +209     
==========================================
+ Hits        16747    16845      +98     
- Misses       5916     6027     +111
Flag Coverage Δ
unittests 73.64% <43.46%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic force-pushed the DIS-2136_add-schedlgu-parser branch from 313394a to 66fa77a Compare January 23, 2024 11:55
@Horofic Horofic requested a review from Poeloe January 23, 2024 11:57
@Horofic Horofic force-pushed the DIS-2136_add-schedlgu-parser branch 2 times, most recently from 85e2baa to 23aefc3 Compare January 23, 2024 13:48
@Horofic Horofic force-pushed the DIS-2136_add-schedlgu-parser branch from 23aefc3 to b9922f9 Compare January 23, 2024 13:50
@Poeloe Poeloe self-requested a review January 23, 2024 13:56
Poeloe
Poeloe approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Horofic Horofic merged commit 72774a2 into main Jan 23, 2024
24 of 26 checks passed
@Horofic Horofic deleted the DIS-2136_add-schedlgu-parser branch January 23, 2024 14:11
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
@Horofic
Add schedlgu.txt file parser (#511)
00c388c 
(DIS-2136)
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
@Horofic @Zawadidone
Add schedlgu.txt file parser (fox-it#511)
4e905c0 
(DIS-2136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Poeloe Poeloe Poeloe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Horofic @Poeloe