Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pytest to a version <8.0.0 for now #517

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Jan 31, 2024

Some tests seem to be dependent on the order they are executed and will fail with pytest 8.0.0's new test collection order.

(DIS-2970)

Some tests seem to be dependent on the order they are executed and will
fail with pytest 8.0.0's new test collection order.

(DIS-2970)
@pyrco pyrco requested a review from Miauwkeru January 31, 2024 09:31
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bf1a21) 73.51% compared to head (a2e57e1) 73.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   73.51%   73.76%   +0.24%     
==========================================
  Files         276      276              
  Lines       22997    22997              
==========================================
+ Hits        16906    16963      +57     
+ Misses       6091     6034      -57     
Flag Coverage Δ
unittests 73.76% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco merged commit 9aec3c3 into main Jan 31, 2024
30 checks passed
@pyrco pyrco deleted the feature/dis-2970_pin-pytest-version branch January 31, 2024 10:00
@JSCU-CNI JSCU-CNI mentioned this pull request Jan 31, 2024
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Some tests seem to be dependent on the order they are executed and will
fail with pytest 8.0.0's new test collection order.

(DIS-2970)
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Some tests seem to be dependent on the order they are executed and will
fail with pytest 8.0.0's new test collection order.

(DIS-2970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants