Add MUI support for timezone translations #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
requested changes
Jan 31, 2024
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Schamper
previously approved these changes
Jan 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 73.79% 73.80% +0.01%
==========================================
Files 276 277 +1
Lines 23040 23050 +10
==========================================
+ Hits 17003 17013 +10
Misses 6037 6037
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I accidentally broke the test so we have to merge #519 first.. 😅 |
Schamper
approved these changes
Feb 1, 2024
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
datetimeplugin when running Dissect against Windows distributions with a different locale. The plugin assumes Python has access to the generateden-USlocale on the machine which it is run from.Non-English distributions of Windows contain a local translation in the
Display,DltandStdkeys inHKLM\\Software\\Microsoft\\Windows NT\\CurrentVersion\\Time Zones. Previously this would break thedatetimeplugin and any other plugins usingdatetime.tzinfoto convert timestamps to UTC.This is fixed by using a lookup table (exported from
C:/Windows/System32/en-US/tzres.dll.mui) and theMUI_Display,MUI_DltandMUI_Stdkeys in timezone registry keys. TheseMUI_*keys contain a registry string redirection value which point to the English translation of a timezone intzres.dll.mui.