Fix some issues with tests not being independent from other tests #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrco
force-pushed
the
feature/dis-2971_fix-test-independency
branch
from
4806e5f to
2a042d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
=======================================
Coverage 73.69% 73.69%
=======================================
Files 277 277
Lines 23056 23056
=======================================
Hits 16990 16990
Misses 6066 6066
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
requested changes
Feb 6, 2024
pyrco
force-pushed
the
feature/dis-2971_fix-test-independency
branch
from
2a042d3 to
5a483a5
Compare
Miauwkeru
approved these changes
Feb 8, 2024
Schamper
approved these changes
Feb 8, 2024
These are due to the tests (inadvertently) changing global state. (DIS-2971)
pyrco
force-pushed
the
feature/dis-2971_fix-test-independency
branch
from
5a483a5 to
ce45dd3
Compare
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
These are due to the tests (inadvertently) changing global state. (DIS-2971)
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
…x-it#526) These are due to the tests (inadvertently) changing global state. (DIS-2971)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are due to the tests (inadvertently) changing global state.
(DIS-2971)