Add JSON and YAML support to configutil #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
reviewed
Feb 6, 2024
dissect/target/helpers/configutil.py
Outdated
| @@ -20,6 +21,7 @@ | |||
| Union, | |||
| ) | |||
|
|
|||
| import yaml | |||
There was a problem hiding this comment.
What library is this from? A yaml library is not always available, unless Python has one in the standard library these days?
There was a problem hiding this comment.
added guards for it, and improved the logging.
@narimantos I only worked on yaml this round, didn't touch toml yet
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 73.62% 73.65% +0.02%
==========================================
Files 277 277
Lines 23083 23124 +41
==========================================
+ Hits 16996 17032 +36
- Misses 6087 6092 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Miauwkeru
force-pushed
the
DIS-2160_add-json-support
branch
from
6109468 to
8450cf4
Compare
Poeloe
requested changes
Feb 13, 2024
Miauwkeru
force-pushed
the
DIS-2160_add-json-support
branch
from
a5d5a4e to
4735fd6
Compare
Co-authored-by: Paul M <22234727+Poeloe@users.noreply.github.com>
Miauwkeru
force-pushed
the
DIS-2160_add-json-support
branch
from
4735fd6 to
aa486ff
Compare
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-2160)