-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password extraction to browser plugins #541
Add password extraction to browser plugins #541
Conversation
tests/_data/plugins/apps/browser/chromium/unix/basic/Login Data
Outdated
Show resolved
Hide resolved
Implemented your feedback in d694c9b. |
I've committed some small changes with 4834771. Mostly type hint, but also the option to decrypt an DPAPI secret of a specific user. Lmk if this still works as expected. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
==========================================
+ Coverage 74.99% 75.02% +0.02%
==========================================
Files 288 288
Lines 24192 24588 +396
==========================================
+ Hits 18143 18447 +304
- Misses 6049 6141 +92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can you rebase on main? Unfortunately due to a bug in GitHub I can't fix LFS issues on PR branches. Protip, |
Could you open a PR on our fork to fix this perhaps @Schamper? |
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Computer Network Investigation <121175071+JSCU-CNI@users.noreply.github.com>
Co-authored-by: Computer Network Investigation <121175071+JSCU-CNI@users.noreply.github.com>
6443a11
to
42fe5b5
Compare
Fixed it I think. |
This reverts commit 3ade668.
Thanks! |
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
This PR adds support for extracting saved passwords and decrypting cookie values from Chromium-based browsers and Firefox on both Windows and Linux targets.
This PR also adds support for decrypting DPAPI user secrets as the current DPAPI implementation only accounts for system secrets.