Add a decryption function to use on a local esxi target #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
==========================================
+ Coverage 73.95% 73.98% +0.02%
==========================================
Files 284 284
Lines 23499 23521 +22
==========================================
+ Hits 17379 17401 +22
Misses 6120 6120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
requested changes
Feb 19, 2024
Schamper
requested changes
Feb 19, 2024
Comment on lines
245
to
252
| local_tgz = BytesIO( | ||
| subprocess.run( | ||
| ["crypto-util", "envelope", "extract", "--aad", "ESXConfiguration", f"/{local_tgz_ve.as_posix()}", "-"], | ||
| capture_output=True, | ||
| ).stdout | ||
| ) | ||
|
|
||
| return local_tgz |
There was a problem hiding this comment.
Suggested change
| local_tgz = BytesIO( | |
| subprocess.run( | |
| ["crypto-util", "envelope", "extract", "--aad", "ESXConfiguration", f"/{local_tgz_ve.as_posix()}", "-"], | |
| capture_output=True, | |
| ).stdout | |
| ) | |
| return local_tgz | |
| result = subprocess.run( | |
| ["crypto-util", "envelope", "extract", "--aad", "ESXConfiguration", f"/{local_tgz_ve.as_posix()}", "-"], | |
| capture_output=True, | |
| ) | |
| return BytesIO(result.stdout) |
This maybe looks a bit nicer.
| target.log.warning( | ||
| "local.tgz is encrypted but static decryption failed, attempting dynamic decryption using crypto-util" | ||
| ) | ||
| local_tgz = _decrypt_crypto_util(local_tgz_ve) |
There was a problem hiding this comment.
What if this fails, btw? Maybe add a case and log message for that too.
There was a problem hiding this comment.
I added some checks for this specific case
Schamper
requested changes
Feb 20, 2024
Schamper
approved these changes
Feb 20, 2024
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Miauwkeru
force-pushed
the
DIS-2995_implement-tpm-mode-dissect
branch
from
2047aea to
282ab97
Compare
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-2995)