Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend documentation for none plugin export type #570

Merged

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented Mar 7, 2024

(DIS-2088)

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.31%. Comparing base (7e0275f) to head (2d9d713).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   74.35%   74.31%   -0.04%     
==========================================
  Files         286      286              
  Lines       23617    23617              
==========================================
- Hits        17560    17551       -9     
- Misses       6057     6066       +9     
Flag Coverage Δ
unittests 74.31% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Poeloe Poeloe requested a review from pyrco March 7, 2024 15:49
@Schamper Schamper changed the title Amend docuementation for None return type for the export decorator Amend documentation for None return type for the export decorator Mar 7, 2024
@Schamper Schamper changed the title Amend documentation for None return type for the export decorator Amend documentation for none plugin export type Mar 7, 2024
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@Poeloe Poeloe requested a review from Schamper March 7, 2024 17:16
@Poeloe Poeloe merged commit 4be9d94 into main Mar 8, 2024
17 of 18 checks passed
@Poeloe Poeloe deleted the feature/amend-documentation-for-none-return-type-export-decorator branch March 8, 2024 09:03
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants