Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefetch to MQTT loader #659

Merged
merged 12 commits into from
Apr 15, 2024
Merged

Add prefetch to MQTT loader #659

merged 12 commits into from
Apr 15, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-3094)

@Schamper Schamper changed the title add prefetch to MQTT loader Add prefetch to MQTT loader Apr 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 74.99%. Comparing base (bdd4426) to head (94fd42f).

Files Patch % Lines
dissect/target/loaders/mqtt.py 82.35% 6 Missing ⚠️
dissect/target/tools/query.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   74.97%   74.99%   +0.01%     
==========================================
  Files         288      288              
  Lines       24172    24192      +20     
==========================================
+ Hits        18124    18143      +19     
- Misses       6048     6049       +1     
Flag Coverage Δ
unittests 74.99% <80.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Miauwkeru
Miauwkeru previously approved these changes Apr 15, 2024
@Miauwkeru
Copy link
Contributor

Acked, but do add the from __future__ import annotations to the start of the test file

cecinestpasunepipe and others added 12 commits April 15, 2024 18:34
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
@cecinestpasunepipe cecinestpasunepipe merged commit 2c14aa5 into main Apr 15, 2024
16 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-3094_MQTT_Cache branch April 15, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants