Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback mount sysvol to C: if not mounted to another drive letter #671

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Apr 9, 2024

Fixes #666

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.90%. Comparing base (52c4480) to head (e2d076c).

Files Patch % Lines
dissect/target/plugins/os/windows/_os.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   74.90%   74.90%           
=======================================
  Files         288      288           
  Lines       24109    24115    +6     
=======================================
+ Hits        18059    18064    +5     
- Misses       6050     6051    +1     
Flag Coverage Δ
unittests 74.90% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Poeloe Poeloe self-requested a review April 9, 2024 11:06
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Schamper Schamper merged commit ab8104f into main Apr 9, 2024
16 checks passed
@Schamper Schamper deleted the mount-sysvol-fallback branch April 9, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: No recycle bins found when using dissect-3.13
3 participants