Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESXi OS when no local state exists yet #784

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Aug 2, 2024

When the hypervisor is not fully installed yet, the local state file may not exist yet.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (e3becf6) to head (456c211).

Files Patch % Lines
dissect/target/plugins/os/unix/esxi/_os.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   75.26%   75.26%   -0.01%     
==========================================
  Files         296      296              
  Lines       25573    25575       +2     
==========================================
  Hits        19248    19248              
- Misses       6325     6327       +2     
Flag Coverage Δ
unittests 75.26% <81.25%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic self-requested a review August 2, 2024 12:56
@Schamper Schamper merged commit 5d19f13 into main Aug 2, 2024
18 checks passed
@Schamper Schamper deleted the fix-esxi-no-local branch August 2, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants