Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast custom --max-size to integer in yara plugin #811

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Aug 7, 2024

This PR fixes --max-size functionality.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (ac8ee68) to head (02b7088).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   75.45%   75.45%           
=======================================
  Files         296      296           
  Lines       25629    25629           
=======================================
  Hits        19339    19339           
  Misses       6290     6290           
Flag Coverage Δ
unittests 75.45% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic merged commit fabbdf9 into fox-it:main Aug 7, 2024
18 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/yara-int branch August 8, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants