Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice for PyPy users #829

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add notice for PyPy users #829

merged 1 commit into from
Aug 26, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-3295)

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.51%. Comparing base (3822b47) to head (d8a712c).
Report is 1 commits behind head on main.

Files Patch % Lines
dissect/target/tools/shell.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   75.51%   75.51%           
=======================================
  Files         305      305           
  Lines       26343    26348    +5     
=======================================
+ Hits        19893    19897    +4     
- Misses       6450     6451    +1     
Flag Coverage Δ
unittests 75.51% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@narimantos
Copy link
Contributor

We wait until we they do a release? pypy/pypy#5006

@cecinestpasunepipe
Copy link
Contributor Author

We wait until we they do a release? pypy/pypy#5006

Yes, let's give them some time to respond before we implement the notice.
If the manage to fix the issue we can probably do a version check as well, and urge our users to download the latest pypy.

@cecinestpasunepipe cecinestpasunepipe merged commit 6968253 into main Aug 26, 2024
18 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-3295_PyPy_Notice branch August 26, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants