Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move helpers/network_manager.py to plugins/os/unix/linux/network_manager.py #869

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

Miauwkeru
Copy link
Contributor

  • Move network_manager.py to os/unix
  • Update the typing on network_managers.py

@Miauwkeru Miauwkeru requested a review from pyrco October 1, 2024 09:23
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.30%. Comparing base (28acbef) to head (39d0940).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/target/plugins/os/unix/linux/network_managers.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   76.31%   76.30%   -0.02%     
==========================================
  Files         312      312              
  Lines       26822    26823       +1     
==========================================
- Hits        20470    20467       -3     
- Misses       6352     6356       +4     
Flag Coverage Δ
unittests 76.30% <63.63%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should be moved under the ./linux/ subdir as it is very Linux specific.

@Miauwkeru Miauwkeru changed the title Move helpers/network_manager.py to plugins/os/unix/network_manager.py Move helpers/network_manager.py to plugins/os/unix/linux/network_manager.py Oct 1, 2024
@Miauwkeru Miauwkeru requested a review from pyrco October 1, 2024 11:08
@Miauwkeru Miauwkeru requested a review from pyrco October 1, 2024 13:16
@Miauwkeru Miauwkeru force-pushed the move-network-manager branch from 7cf651b to 966bc2e Compare October 3, 2024 11:16
@Miauwkeru Miauwkeru merged commit a395d13 into main Oct 4, 2024
16 of 18 checks passed
@Miauwkeru Miauwkeru deleted the move-network-manager branch October 4, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants