-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move helpers/network_manager.py to plugins/os/unix/linux/network_manager.py #869
Conversation
Miauwkeru
commented
Oct 1, 2024
- Move network_manager.py to os/unix
- Update the typing on network_managers.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
==========================================
- Coverage 76.31% 76.30% -0.02%
==========================================
Files 312 312
Lines 26822 26823 +1
==========================================
- Hits 20470 20467 -3
- Misses 6352 6356 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file should be moved under the ./linux/
subdir as it is very Linux specific.
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
7cf651b
to
966bc2e
Compare