Improve robustness of journal plugin #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zawadidone
reviewed
Oct 1, 2024
Schamper
requested changes
Oct 7, 2024
Schamper
requested changes
Oct 9, 2024
JSCU-CNI
force-pushed
the
improvement/journal-plugin
branch
from
52233ce to
e47650c
Compare
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 76.71% 76.65% -0.06%
==========================================
Files 316 316
Lines 27069 27086 +17
==========================================
- Hits 20765 20764 -1
- Misses 6304 6322 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
requested changes
Oct 15, 2024
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Schamper
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #878. We added some sanity checks to make sure the journal plugin does not break if it encounters values that do not match the format we expected.