-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow RegfValue.type to fall back to int #956
Conversation
Would you mind adding a test case for this behaviour in Not sure, but should this not return |
Using |
This fix is not for catching |
Unfortunately it seems |
You could go the cstruct route and insert new members as needed: https://github.com/fox-it/dissect.cstruct/blob/main/dissect/cstruct/types/enum.py#L183 |
Added in 308fda1. Perhaps the Enum should be moved to the |
Maybe, I'm fine with it in here for now since this enum serves more as an abstraction layer than a "parsing" enum. |
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
=======================================
Coverage 77.90% 77.91%
=======================================
Files 324 324
Lines 27857 27865 +8
=======================================
+ Hits 21702 21710 +8
Misses 6155 6155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR fixes edge cases where
RegfValue.type
cannot be translated to theRegistryValueType
enum.