Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipinterface type to fieldtypes.net #160

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

Miauwkeru
Copy link
Contributor

No description provided.

@Miauwkeru Miauwkeru requested a review from yunzheng February 6, 2025 14:56
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.94%. Comparing base (380ff1c) to head (6268302).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
flow/record/fieldtypes/net/ip.py 88.09% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   82.91%   82.94%   +0.03%     
==========================================
  Files          34       34              
  Lines        3518     3554      +36     
==========================================
+ Hits         2917     2948      +31     
- Misses        601      606       +5     
Flag Coverage Δ
unittests 82.94% <88.63%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunzheng yunzheng changed the title Add ipinterface type to fieltype.net Add ipinterface type to fieldtypes.net Feb 6, 2025
@Miauwkeru Miauwkeru force-pushed the DIS-3586_create-ip-interface-field-type branch from 407ac03 to d54f81c Compare February 10, 2025 11:37
@Miauwkeru Miauwkeru requested a review from yunzheng February 12, 2025 14:37
@Miauwkeru Miauwkeru requested a review from yunzheng February 17, 2025 11:56
@yunzheng yunzheng force-pushed the DIS-3586_create-ip-interface-field-type branch from 3b3ec78 to 6268302 Compare February 17, 2025 12:17
@Miauwkeru Miauwkeru merged commit 1f4e711 into main Feb 17, 2025
20 of 22 checks passed
@Miauwkeru Miauwkeru deleted the DIS-3586_create-ip-interface-field-type branch February 17, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants