Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMAP IDLE is missing from server-reported capabilities again #504

Closed
Dr-Escher opened this issue Jun 23, 2022 · 3 comments
Closed

IMAP IDLE is missing from server-reported capabilities again #504

Dr-Escher opened this issue Jun 23, 2022 · 3 comments
Assignees
Labels
bug Something isn't working. ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele

Comments

@Dr-Escher
Copy link

Not sure if this is the exact same issue as #446 (which got fixed), however v0.6.0 shows similar behaviour again.

Describe the bug

Latest maddy doesn't report the IMAP IDLE capability, rendering message pushing unavailable.

Steps to reproduce

Connect to maddy v0.6.0 840d687 via IMAP

Log files

[Parent 2668: IMAP]: I/IMAP 7f257a1af800:NA:CreateNewLineFromSocket: * OK [CAPABILITY IMAP4rev1 LITERAL+ SASL-IR CHILDREN UNSELECT MOVE APPENDLIMIT AUTH=PLAIN AUTH=LOGIN COMPRESS] IMAP4rev1 Service Ready

Configuration file

Default configuration

Environment information

  • maddy version: v0.6.0
  • Debian version: 11.3
@Dr-Escher Dr-Escher added the bug Something isn't working. label Jun 23, 2022
@foxcpp foxcpp self-assigned this Jun 23, 2022
@foxcpp
Copy link
Owner

foxcpp commented Jun 23, 2022

You are right, this is exactly the same issue - go-imap v2 apparently was never updated to include fix that was made for v1 (version used by maddy 0.5).

foxcpp added a commit that referenced this issue Jun 23, 2022
Merged upstream v1 fixes into v2 branch.

See #504.
@foxcpp foxcpp added the ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele label Jun 23, 2022
@foxcpp
Copy link
Owner

foxcpp commented Jun 23, 2022

Should be fixed in 0.6.1. Thanks for letting me know.

@foxcpp foxcpp closed this as completed Jun 23, 2022
@Dr-Escher
Copy link
Author

Yes, I can confirm this is fixed in v0.6.1 bbaea04

Awesome, thank you.

shift pushed a commit to shift/maddy that referenced this issue Jul 5, 2022
Merged upstream v1 fixes into v2 branch.

See foxcpp#504.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele
Projects
None yet
Development

No branches or pull requests

2 participants