Update local-install to create $HOME/.foxglove-studio folder if snap is not present
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p is not present Fixes: #98
achim-k
approved these changes
Mar 31, 2023
defunctzombie
deleted the
roman/fg-2453-extensions-dont-install-unless-foxglove
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #91 we updated the install logic to install correctly for snap users. In that logic we check for the presence of specific directories before installing (whereas before we would always make the directory). Since then we've learned that debian package users don't actually have a
$HOME/.foxglove-studio/extensionsdirectory prior to actually installing an extension. This meant that thelocal-installscript would fail to install a developer's extension locally unless they had installed one via the marketplace or made the extensions dir manually.This change updates the
installcommand to pro-actively create the$HOME/.foxglove-studio/extensionsdirectory if it does not exist. To avoid creating this directory for snap users, we first check for the presence of the snap/foxglove-studio/current directory which tells us if a snap is installed for foxglove-studio. If the snap is used then we only install in the snap directory.We'll see how this holds up to other create ways folks expected the local install command to work.
Fixes: #98