Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device_name argument to create_event method #36

Open
esthersweon opened this issue Apr 7, 2022 · 2 comments
Open

Add device_name argument to create_event method #36

esthersweon opened this issue Apr 7, 2022 · 2 comments
Labels
feature New feature or request

Comments

@esthersweon
Copy link

Description

  • Add device_name argument to create_event method, to correspond with REST API's request signature
@esthersweon esthersweon added the bug Something isn't working label Apr 7, 2022
@esthersweon esthersweon mentioned this issue Apr 13, 2022
Closed
@foxymiles
Copy link
Contributor

I think we should change this from a bug to a feature request since the consensus of our conversation about this is that a lot of other changes in console and DP would be necessary to implement this consistently in a way that makes sense to users.

@esthersweon esthersweon added feature New feature or request and removed bug Something isn't working labels May 16, 2022
@esthersweon
Copy link
Author

@foxymiles - Makes sense; updated to a feature request.

@foxymiles foxymiles removed their assignment Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add device_name arg to create_event call foxglove/foxglove-python
2 participants
@esthersweon @foxymiles