Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device_name arg to create_event call #41

Closed
wants to merge 1 commit into from
Closed

Add device_name arg to create_event call #41

wants to merge 1 commit into from

Conversation

esthersweon
Copy link

Public-Facing Changes

  • Add device_name arg to create_event call

Resolves #36

@foxymiles
Copy link
Contributor

I've held off on adding this because I think it's worth us having a meta-conversation about how we want people to identify devices across all the API calls. I think we should be consistent.

@esthersweon esthersweon force-pushed the esther/device_name branch 2 times, most recently from 8a3324b to edffa28 Compare April 13, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxymiles foxymiles Awaiting requested review from foxymiles

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add device_name argument to create_event method
2 participants
@esthersweon @foxymiles