Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcap-ros1-support: Missing dependency on pyyaml #955

Closed
achim-k opened this issue Aug 28, 2023 · 0 comments · Fixed by #956
Closed

mcap-ros1-support: Missing dependency on pyyaml #955

achim-k opened this issue Aug 28, 2023 · 0 comments · Fixed by #956
Labels
bug Something isn't working

Comments

@achim-k
Copy link
Contributor

achim-k commented Aug 28, 2023

Description
mcap-ros1-support: Missing dependency on pyyaml

  • Version: mcap_ros1_support @ 0.7.0
  • Platform: linux (python:3.11 docker image)

Steps To Reproduce

# docker run -it --rm python:3.11 bash

pip install mcap-ros1-support
python -c "from mcap_ros1.decoder import DecoderFactory"

Raises

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.11/site-packages/mcap_ros1/decoder.py", line 10, in <module>
    from ._vendor.genpy import dynamic  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/mcap_ros1/_vendor/genpy/__init__.py", line 34, in <module>
    from . message import Message, SerializationError, DeserializationError, MessageException, struct_I
  File "/usr/local/lib/python3.11/site-packages/mcap_ros1/_vendor/genpy/message.py", line 49, in <module>
    import yaml
ModuleNotFoundError: No module named 'yaml'

Confirm that after pip install pyyaml, the import works

Expected Behavior
pyyaml should be installed with mcap-ros1-support

@achim-k achim-k added the bug Something isn't working label Aug 28, 2023
achim-k added a commit that referenced this issue Aug 28, 2023
achim-k added a commit that referenced this issue Sep 1, 2023
### Public-Facing Changes
mcap-ros1-support: Add missing pyyaml dependency

### Description
Fixes #955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant