address SVG logo issue #1157
Merged
address SVG logo issue #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indirectlylit
commented
Apr 10, 2024
jtbandes
approved these changes
Apr 10, 2024
indirectlylit
force-pushed
the
devon/fg-7251-logos-are-cut-off-on-mcapdev
branch
from
bb4293e to
08066e1
Compare
indirectlylit
force-pushed
the
devon/fg-7251-logos-are-cut-off-on-mcapdev
branch
from
08066e1 to
496d33c
Compare
|
@jtbandes cleaned up a bit to isolate ugliness |
indirectlylit
force-pushed
the
devon/fg-7251-logos-are-cut-off-on-mcapdev
branch
from
ee14143 to
13e4d7d
Compare
jtbandes
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
none
Description
As described in facebook/docusaurus#8297, the default webpack config for docusaurus has svgo configured to replace
idattributes with simple incrementing characters like"a","b", etc. This leads to ID conflicts between logos and incorrect clipping behavior.This PR modifies the underlying webpack config to disable changes to ID attributes.
Note that on mac, I was only able reproduce the visual clipping issue in Safari; FF and Chrome seemed to ignore the incorrectly duplicated IDs .