Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead members in McapReader #1199

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Remove dead members in McapReader #1199

merged 1 commit into from
Jul 24, 2024

Conversation

kyle-basis
Copy link
Contributor

Changelog

Remove unused startTime_ and endTime_ members of McapReader that were initialized and never used.

Docs

None

Description

This is fairly self evident - if the code compiles it should be the correct change.

indirectlylit
indirectlylit approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@indirectlylit indirectlylit merged commit 5add9e2 into foxglove:main Jul 24, 2024
23 checks passed
@jtbandes jtbandes mentioned this pull request Sep 24, 2024
Merged
jtbandes added a commit that referenced this pull request Sep 25, 2024
@jtbandes
cpp: bump version to 1.4.1 (#1241)
0ebaf69 
Bump version to 1.4.1. Changes include:

- #1239 
- #1199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indirectlylit indirectlylit indirectlylit approved these changes

@james-rms james-rms Awaiting requested review from james-rms james-rms is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-basis @indirectlylit