Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIT License #601

Merged
merged 1 commit into from
Sep 23, 2022
Merged

MIT License #601

merged 1 commit into from
Sep 23, 2022

Conversation

amacneil
Copy link
Contributor

@amacneil amacneil commented Sep 22, 2022 •
edited
Loading

Relicense from Apache-2.0 to MIT

Rationale:

  1. Consistency: all other Foxglove-developed libraries are MIT licensed
  2. Does not require per-file license headers (which we have failed to adhere to)
  3. Similarly permissive

amacneil
amacneil commented Sep 22, 2022
View reviewed changes
cpp/mcap/LICENSE
@@ -1,202 +0,0 @@

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this duplicate file? We did not duplicate the LICENSE file into other language directories.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was required for conan, can’t say for sure though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @jtbandes said. The LICENSE should also be in the typescript directory, since npm packaging wants to distribute a license file as part of the npm bundle. I can't speak for other language package managers, but I thought pypi was similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I pushed copies of the LICENSE file to cpp/mcap and typescript/core directories.

Do you think I could replace these with symlinks, or do they need to be complete copies?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete copies :-\

jhurliman
jhurliman suggested changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@jhurliman jhurliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cpp/mcap/LICENSE file should be modified, not deleted

@amacneil amacneil merged commit 3f8d900 into main Sep 23, 2022
@amacneil amacneil deleted the adrian/mit branch September 23, 2022 04:24
@jtbandes jtbandes mentioned this pull request Sep 26, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhurliman jhurliman jhurliman approved these changes

@jtbandes jtbandes jtbandes approved these changes

@defunctzombie defunctzombie Awaiting requested review from defunctzombie

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amacneil @jtbandes @jhurliman