Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: fix bug where mcap merge crashed on channels with schema_id == 0 #830

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

james-rms
Copy link
Collaborator

Public-Facing Changes

  • Fixes a crash in mcap merge where a schemaless channel (ie. one with schema_id == 0) would cause the CLI tool to crash.

Fixes #829

@james-rms james-rms requested a review from wkalt February 23, 2023 05:08
@james-rms james-rms force-pushed the james/fg-2122-mcap-merge-fails-on-missing-schema branch from 2311688 to 3ad951e Compare February 23, 2023 05:09
@james-rms james-rms enabled auto-merge (squash) February 23, 2023 05:17
@james-rms james-rms merged commit 33fa531 into main Feb 23, 2023
@james-rms james-rms deleted the james/fg-2122-mcap-merge-fails-on-missing-schema branch February 23, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

mcap merge fails on missing schema
1 participant