feat(cli): Add CBOR and JSON schemaless decoding for cat --json
#848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jon-chuang
commented
Mar 13, 2023
python/mcap/tests/test_writer.py
Outdated
| @pytest.mark.parametrize( | ||
| "null_schema", [(True,), (False,)] | ||
| ) | ||
| def test_generate_sample_cbor_data(null_schema: bool): |
There was a problem hiding this comment.
This is the wrong place for this test, but we should test this functionality somewhere since it was also the source of a SIGSEV...
There was a problem hiding this comment.
Where should we put this test?
jtbandes
reviewed
Mar 13, 2023
jon-chuang
changed the title
cat --json + fix SIGSEVcat --json
…-cli-encodings-and-fix
|
Closing this PR since we haven't seen much community interest in CBOR, and we've identified that the first step needs to be an update to the spec / well-known types registry (see https://github.com/foxglove/studio/pull/5574#issuecomment-1563425843 & https://github.com/foxglove/studio/pull/5574#issuecomment-1563482157). Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
mcap cat --jsonallows for schemaless json and cbor encodingsDescription
mcap cat --jsonallows for schemaless json and cbor encodingsDepends on:
#763
#847