[Rust - bugfix] read_record_from_slice checking wrong size of buffer wrong #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 1, 2023 15:49
dmweis
changed the title
jtbandes
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Looks correct to me, adding @james-rms for a second sanity check.
james-rms
approved these changes
Oct 4, 2023
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
…wrong (foxglove#961) ### Public-Facing Changes There should be no changes in public API caused by this change. ### Description `read_record_from_slice` was checking that buffer size is bigger than 5 but was trying to read a `u8` and `u64` which are in total 9 bytes. This was causing panics when reading malformed mcap files or otherwise malformed streams. I added some simple tests as well but they aren't very robust (I don't check parsing of records).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
There should be no changes in public API caused by this change.
Description
read_record_from_slicewas checking that buffer size is bigger than 5 but was trying to read au8andu64which are in total 9 bytes. This was causing panics when reading malformed mcap files or otherwise malformed streams.I added some simple tests as well but they aren't very robust (I don't check parsing of records).