Add parameter type name field to spec #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Mar 14, 2023
achim-k
added a commit
that referenced
this pull request
Mar 14, 2023
### Public-Facing Changes None ### Description Should have done that in #396
achim-k
added a commit
to foxglove/ros-foxglove-bridge
that referenced
this pull request
Mar 24, 2023
### Public-Facing Changes - Add support for byte array params [ROS2] ### Description Adds support for byte array parameters according to the ws-protocol specification update made in foxglove/ws-protocol#396 Fixes #198
pezy
pushed a commit
to pezy/ws-protocol
that referenced
this pull request
Jul 27, 2023
### Public-Facing Changes - Add optional parameter field `type` ### Description Adds the optional field `type` to the Parameter struct for cases where the parameter type can't be deduced from the type of the `value` field alone.
pezy
pushed a commit
to pezy/ws-protocol
that referenced
this pull request
Jul 27, 2023
### Public-Facing Changes None ### Description Should have done that in foxglove#396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
typeDescription
Adds the optional field
typeto the Parameter struct for cases where the parameter type can't be deduced from the type of thevaluefield alone.