-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide choice to spawn an avatar for the host #283
base: main
Are you sure you want to change the base?
Conversation
…piler hits error if function doesnt exist, so typos are caught with static RPC functions)
Since only the example project is modified in this PR, the version bumps for the netfox libraries aren't necessary. |
forest brawl is part of netfox.extras |
Based on the folder structure and the documentation of Forest Brawl + netfox.extras it seems to be a separate thing from that. Why do you think it is part of netfox.extras? |
Because forest-brawl is inside the netfox extras folder
It is inside netfox.extras folder, just like weapons Edit: I updated all netfox package version numbers (base, internals, noray, extras) because with each update, regardless of which package it touches, they all have the same version number. This makes sense to keep the version number non-confusing |
Makes sense now. No worries, take your time! |
reverted 1 version bump
reverted 1 version bump
reverted 1 version bump
My local branch was deviated from this upstream branch and my API token has expired, so I decided to do the version bump from the browser (github) but it only accepted 1 file change per commit |
@TheYellowArchitect I mean what's the benefit of this PR? Especially since this concerns Forest Brawl, and Forest Brawl is set up for players to host. |
A clear example of how to include or not include the host as a player. Also do not look down at forest brawl as just an example. Many games can build off it, I'm sure some users will. My game for example is a top-down shooter, so I simply took forest-brawl as is, and did heavy changes, instead of starting from scratch. After all, netcoding is the foundation of every game, the starting spot (you cannot convert a singleplayer game to a multiplayer game), so forest-brawl is naturally usable this way. |
Please refrain from statements like these. They adds nothing to your point, but imply falsehoods. And, to clarify, Forest Brawl is an example project, not a template. It is meant to give users a general feel on how netfox fits into a game project, and demonstrate some mechanics. It is not geared towards being a starter kit for new projects. I'm glad if it can help people start their projects, but it's still important to keep in mind what Forest Brawl is, and not force it to be something it is not. I'm open to building template projects, if there's demand and if we can clearly define what a starter kit should be 🙂 I agree on the use case of people running the game in dedicated server mode. For that to be a feature, we'd need not only a single variable, but also a UI update. I think either a checkbox or dedicated button could work, just make sure that it's present on both LAN and noray tabs. Probably with a label like "Host only". |
I used it as a template for my game, and it works finely. Because you don't see it as a template, doesn't mean users will not use it as a template.
It was literally my starter kit for my new project.
I am not forcing anything, I am simply saying I used it as a template, and surely others will too.
I am unfamiliar with noray. But I can do the UI update as an extension of this PR if you wish. A checkbox which toggles this boolean. |
That still does not make it a template.
That still does not make it a starter kit.
I don't know, insisting on the points above surely feels like it 🙂 I'm happy if people can use Forest Brawl as a template or as a starter, but it is still neither of those things. This is important because being an example game, it has its own scope. This means that I don't want to add features that would be nice as a template or a starter, I want to add features that make sense in terms of the game itself. You don't need to be familiar with noray, just expose the variable on the Forest Brawl UI. Thanks! |
Quite simple and self-explanatory. If the boolean is false, host simply doesn't spawn an avatar for any player. And for clients,
MultiplayerSpawner
simply doesn't spawn avatar 1 because he never existed.