Refactored input batching and input submission #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…piler hits error if function doesnt exist, so typos are caught with static RPC functions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been the established convention for all
_statesand_ticksand basically property dictionaries to be in the format of[tick][property]Input batching/redundancy is the only property dictionary which instead works with
[property][tick].With this PR, it now works like the rest (
[tick][property]) and it should be easier to read, and also improves performance as well because inputs are cached in_batched_inputs_to_broadcastEdit: Give me a day or two to stress-test this, because I see some jitter in 200ms and want to confirm this didn't exist in
mainbranch