Variable Rename: props
to property_entries
#308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easy to be confused with the variable names because of no static typings.
properties
for example are not properties but PropertyEntries.It makes it confusing to the reader as to what any variable is, especially new users to the codebase.
This PR had to be made because in the netfox discord I saw someone asking 'how can I sync props' and someone asked 'properties or props' and the reply was actually props ala prop hunt lol
Basically the current naming convention causes a lot of confusion.
The first suggestion and the implementation of this is to convert
props
toproperty_entries
The second suggestion is to rename
property
of typeString
toproperty_name
, and have the nameproperty
be thePropertyEntry
itself. I am against this second suggestion because this repo has no static typing as coding convention, soproperty
beingPropertyEntry
is just weird, whileproperty_entry
being of typePropertyEntry
is intuitive.